Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad refactor of WebSocket getMappings method. #5861

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Fix bad refactor of WebSocket getMappings method. #5861

merged 1 commit into from
Jan 12, 2021

Conversation

lachlan-roberts
Copy link
Contributor

Signed-off-by: Lachlan Roberts lachlan@webtide.com

@lachlan-roberts
Fix bad refactor of getMappings method.
6e6f83c 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
Copy link
Contributor Author

@gregw do I need to deprecate an add the correct method, or is it okay to change this?
I think this accidentally happened from a bad refactor by Intellij and slipped through the review.

gregw
gregw approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok to change this. But also OK to add deprecated aliases if you feel you must.

@lachlan-roberts lachlan-roberts merged commit 7aae180 into jetty-10.0.x Jan 12, 2021
@lachlan-roberts lachlan-roberts deleted the jetty-10.0.x-getMappings branch January 12, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lachlan-roberts @gregw